Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DataTable): expandable table size variations alignment issues #8080

Merged
merged 7 commits into from
Mar 25, 2021
Merged

fix(DataTable): expandable table size variations alignment issues #8080

merged 7 commits into from
Mar 25, 2021

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Mar 12, 2021 •
edited
Loading

Closes #4796

Changelog

New

  • adds stories for size variation expandable tables (compact, short, tall)
  • updates padding-left for expandable child row size variations

Removed

  • removed unneeded code

Testing

  • Review expandable table size variations to make sure row height changes for each variation and everything aligns correctly.

@jnm2377 jnm2377 requested a review from a team as a code owner March 12, 2021 18:49
@jnm2377 jnm2377 requested review from a team and aagonzales and removed request for a team March 12, 2021 18:56
@netlify
Copy link

netlify bot commented Mar 12, 2021

Deploy preview for carbon-elements ready!

Built with commit 8664702

https://deploy-preview-8080--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 12, 2021

Deploy preview for carbon-components-react ready!

Built with commit 8664702

https://deploy-preview-8080--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Mar 12, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit bb08aca

https://deploy-preview-8080--carbon-elements.netlify.app

tw15egan
tw15egan reviewed Mar 12, 2021
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the header alignment looks correct (I even tested with sortable variants since that has been giving us issues 😆 ), but it looks like the top/bottom padding has been changed for the normal variant. Just wanted to make sure this was an intentional change:

This PR
Screen Shot 2021-03-12 at 11 25 08 AM

Deployed Storybook
Screen Shot 2021-03-12 at 11 25 18 AM

@netlify
Copy link

netlify bot commented Mar 12, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit bb08aca

https://deploy-preview-8080--carbon-components-react.netlify.app

@jnm2377 jnm2377 changed the title Expand table size variations feat(DataTable): expandable table size variations alignment issues Mar 12, 2021
aagonzales
aagonzales requested changes Mar 15, 2021
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The left-padding of the icon and the focus border size should stay the same across row sizes so the expansion icon is always in the same alignment no matter the row size.

image

@jnm2377 jnm2377 changed the title feat(DataTable): expandable table size variations alignment issues fix(DataTable): expandable table size variations alignment issues Mar 17, 2021
dakahn
dakahn approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once design is satisfied 👍🏽

@jnm2377
Copy link
Contributor Author

jnm2377 commented Mar 25, 2021

@aagonzales sorry it's taken so long for me to push these changes 😓 should be fixed now 👍🏽

aagonzales
aagonzales approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that looks good! thanks for updating.

@jnm2377 jnm2377 merged commit d9eb827 into carbon-design-system:main Mar 25, 2021
@tw15egan tw15egan mentioned this pull request Apr 1, 2021
Merged
12 tasks
@laurenmrice laurenmrice mentioned this pull request Apr 12, 2021
Closed
@aagonzales aagonzales mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan left review comments

@aagonzales aagonzales aagonzales approved these changes

@dakahn dakahn dakahn approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones

Assignees
No one assigned
Labels
status: ready for review 👀 status: visual review 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data table row sizes not applied when expanded content used
4 participants
@jnm2377 @aagonzales @tw15egan @dakahn